Sonobi - Fixed issue where consent_string param could be set as undefined #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d test port expectations to the original 9876 port
…d test port expectations to the original 9876 port
jaiminpanchal27
approved these changes
Jun 1, 2018
Pupis
pushed a commit
to adform/Prebid.js
that referenced
this pull request
Jun 7, 2018
…ined (prebid#2656) * added vp param to trinity request * added lib_name and lib_v to trinity * return null from buildRequests if there is no keymakers * added test case for empty keymaker * only importing functions we need from utils * changed window.pbjs.version to use the gulp repalced macro .version$ * fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port * fixed lint issue * fixed issue where sonobi getUserSync was throwing an error on timeout * sonobi support referrer param * fixed unit test for testing the ref param on bid request * return null from buildRequests if there is no keymakers * fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port * Add gdpr support * only sending consent string if it exists
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
…ined (prebid#2656) * added vp param to trinity request * added lib_name and lib_v to trinity * return null from buildRequests if there is no keymakers * added test case for empty keymaker * only importing functions we need from utils * changed window.pbjs.version to use the gulp repalced macro .version$ * fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port * fixed lint issue * fixed issue where sonobi getUserSync was throwing an error on timeout * sonobi support referrer param * fixed unit test for testing the ref param on bid request * return null from buildRequests if there is no keymakers * fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port * Add gdpr support * only sending consent string if it exists
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
…ined (prebid#2656) * added vp param to trinity request * added lib_name and lib_v to trinity * return null from buildRequests if there is no keymakers * added test case for empty keymaker * only importing functions we need from utils * changed window.pbjs.version to use the gulp repalced macro .version$ * fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port * fixed lint issue * fixed issue where sonobi getUserSync was throwing an error on timeout * sonobi support referrer param * fixed unit test for testing the ref param on bid request * return null from buildRequests if there is no keymakers * fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port * Add gdpr support * only sending consent string if it exists
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
…ined (prebid#2656) * added vp param to trinity request * added lib_name and lib_v to trinity * return null from buildRequests if there is no keymakers * added test case for empty keymaker * only importing functions we need from utils * changed window.pbjs.version to use the gulp repalced macro .version$ * fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port * fixed lint issue * fixed issue where sonobi getUserSync was throwing an error on timeout * sonobi support referrer param * fixed unit test for testing the ref param on bid request * return null from buildRequests if there is no keymakers * fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port * Add gdpr support * only sending consent string if it exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fixed issue where consent_string could be set as undefined